[INCONSISTENCY] Triggered Lifesteal Heals

[Terresquall]

What's the Problem?

To put it simply, triggered lifesteal effects do not heal the target accurately as these effects do not consider damage reduction effects like armor/magic resistance when calculating the amount healed, and this should be corrected.

The spells with these inconsistencies are:

Feast

The damage dealt by Feast is reduced by armor, so unless attacking a 0 armor target, Feast will not deal exactly 4/5/6/7% of the target's HP. However, regardless of the situation, Feast will heal N'aix for 4/5/6/7% of the target's HP anyway.

Currently, in part of Feast's code, the damage and the heal is coded this way:

- Heal target for percentage of target's current hit points.
- Damage target for percentage of target's current hit points.

To fix it, only 2 more lines of code need to be added:

- Save target's current hit point value as variable1
- Damage target for percentage of target's current hit points.
- Take the difference between variable1 and the target's new HP.
- Heal the attacker using the value derived from above.

Soul Steal

The new Soul Steal heals the target receiving HP for 20/40/60/80 hit points, but the amount of HP stolen from the target is reduced/increased depending on magic resistance.

To fix this, Soul Steal has to be recoded slightly to deal triggered damage instead of using the dummy to deal damage, so that the code can retrieve the damage dealt more easily. To find the amount of damage dealt, the same method as N'aix's Feast can be used.

Dismember (Aghanim's)

Aghanim's Dismember has 2 sources of damage--one from the skill's hardcoded mechanics and one through triggers (which also handles the lifesteal). What the code does is that it directly takes the dealt damage (without reduction) and adds it to the caster's HP.

The way around this would be to completely trigger the damage, then use the aforementioned method for Feast and Soul Steal to detect the heal amount.

Brain Sap

The problem with Brain Sap is not with the amount of damage it deals, but with the fact that if the target unit has less hit points than the amount of hit points sapped, it will heal the caster that same amount anyway (i.e. sapping a 150 HP target will heal the caster 300 hit points anyway). This inconsistency needs to be corrected.

Balance Issues?

I think it is only fair that these spells are coded to leech accurate amounts of health. Hardcoded lifesteal effects (e.g. Satanic, Mask of Death, Pugna's Life Drain) all have their healing effects dampened when damage is reduced (and vice versa), and they do not leech more health than the amount that the target has. It's only fair that triggered lifesteal effects do the same.

Moreover, these inconsistencies are probably things that have been overlooked by IceFrog than intended features, as IceFrog has fixed many of these inconsistencies in the past before.

[Quiesce]

Tup tup tup

[Baldoro]

It's a nerf .
Anyway, T-up.

[dominator02]

[gnaLor]

Perhaps it is a feature. By that way, Naixs heal is much stronger than without it. And it should be that strong. If you "fix" it from healing the pure % of the health, we would have to add sth. like steals 10% while only leaching 5% or so.
Well however I think youre right, but we must buff the skill then in one or another way.

Doesnt Brainsap deal pure damage? I think if damage + healed amount are both pure, its ok. Many abilities use pure damage.

Soul Steal should really work as every over lifesteal too. Its definetely codeable. For example with a dummy that is locked to soul keepers position and the dummys hp gained are periodically added to soul keepers hp, not just giving him 20/40/60/80 hp.

"I think it is only fair ..."
Pls dont use the word fair here, weretalking about balance and logic or whatever, but not about whether its fair. As long as the heroes are balanced over all its fine. If we fix a logical thing we should keep the balance, not just take it as a nerf (what it would be here) even if the hero doesnt need a nerf.

[Zangetsu2201]

Well, it would be nice to getall these fixed (maybe it would be too much of a nerf on N'aix, though.)

I don't think that's a feature. I'm not sure about the others, but Soul Steal shouldn't work this way, it was a coding fail...

[Terresquall]

Doesnt Brainsap deal pure damage? I think if damage + healed amount are both pure, its ok. Many abilities use pure damage.

The issue I have with Brain Sap is actually different. It's that it heals for a fixed amount regardless of how much hit points the target has left. A Level 4 Brain Sap sapping a 150HP target actually heals the caster for 300 HP.

[pokerwat]

T-up

[SN0W37]

Originally Posted by Zangetsu2201

I don't think that's a feature. I'm not sure about the others, but Soul Steal shouldn't work this way, it was a coding fail...[/COLOR]

I not sure what you mean by a coding failure but the proposed changed is very easy to do and is quite codable.

@Topic: T-UP, even if its a nerf I feel that all lifesteal should eb teh same whethor its triggered or hardcoded.

[dreamcatcher0]

t UP!

[NoThlnG]

It's a nerf. But T-Up anyway

[gnaLor]

Well I think the fact that brain sap heals the full amount no matter of how much hp the target left has is really sth. strong, that would be a noticeable nerf imo. Its also used for "lasthitting" creeps and healing at the same time, and you dont have to care about to lasthit the creep with exactly 300 hp atm.
I personally think that its very logical that he can sap more health. Cause when the unit dies, there still alot of dead brain there that he can absorb ^^

[Terresquall]

It's a nerf. But T-Up anyway

It's a nerf to keep things consistent. Affected heroes can have other aspects of them buffed to keep them as powerful.

[fr0zenknife]

nooo big nerf dont T-down

[Sonic_Stream]

Yes, really t-up, make it more fair

[Terresquall]

nooo big nerf dont T-down

Numbers can be tweaked. It's plain unfair to hardcoded spells like that.

[HELLRAISER]

At OP. What you dont know is that IceFrog fully knew what he was doing and that the skills works as they were suppose to and their numbers are balanced around this fact. If you "fix" them, then their numbers will greatly increased to re-balance them.

T-DOWN.

[Cáno]

Originally Posted by HELLRAISER

What you dont know is that IceFrog fully knew what he was doing and that the skills works as they were suppose to and their numbers are balanced around this fact.

No. Seeing how poor is the quality of the new code I'm almost certain that Dismember and Soulsteal are effects of IceFrog's oversights.

[Torchic Maniac]

T-up for everything except for Feast.
That change for Feast is too much of a nerf and I don't think it is necessary.

[Green Yoshi]

These effects are not the same as lifesteal items. I see no reason to implement this, it only upsets balance - T-down